Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Upgrade actions #1521

Merged
merged 3 commits into from
Feb 22, 2024
Merged

CI: Upgrade actions #1521

merged 3 commits into from
Feb 22, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 22, 2024 •
edited
Loading

Content

This PR upgrades the versions of the actions we use in the CI, this should solve most "upgrade to node 20" warnings.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1520

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

Test Results

  3 files  ±0   42 suites  ±0   8m 39s ⏱️ +9s
865 tests ±0  865 ✅ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b66015a. ± Comparison against base commit cff2c64.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview February 22, 2024 13:56 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 22, 2024 13:56 — with GitHub Actions Inactive
@Alenar Alenar self-assigned this Feb 22, 2024
@Alenar Alenar marked this pull request as ready for review February 22, 2024 14:00
@Alenar Alenar temporarily deployed to testing-preview February 22, 2024 15:45 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 22, 2024 15:45 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar force-pushed the djo/1520/ci-upgrade-actions branch from c75f5b9 to b66015a Compare February 22, 2024 17:23
@Alenar Alenar temporarily deployed to testing-preview February 22, 2024 17:50 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 22, 2024 17:50 — with GitHub Actions Inactive
@Alenar Alenar merged commit c65486a into main Feb 22, 2024
45 of 51 checks passed
@Alenar Alenar deleted the djo/1520/ci-upgrade-actions branch February 22, 2024 17:52
This was referenced Feb 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @dlachaume